Fix code bug in parse config file. #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Nov 9, 2021
support.c
Outdated
| @@ -246,7 +269,7 @@ void set_source_ip(const char *tac_source_ip) { | |||
| int _pam_parse_arg (const char *arg, char* current_secret, uint current_secret_buffer_size) { | |||
| int ctrl = 0; | |||
|
|
|||
| if (!strcmp (arg, "debug")) { /* all */ | |||
| if (!strcmp (arg, "debug") || !strcmp (arg, "debug=on")) { /* all */ | |||
There was a problem hiding this comment.
Yes this is necessary for debug.
The reason of this change is because the tacplus_nss.conf config file using debug=on to enable debug. so we need change code here to enabled debug with the 'debug=on' setting.
There was a problem hiding this comment.
I am not aware of the syntax of tacplus_nss.conf. I found a sample https://github.com/stemid/tacacs/blob/master/libnss-tacplus/tacplus_nss.conf. Will you support debug=1 ?
qiluo-msft
reviewed
Nov 9, 2021
|
Could you explain the motivation in code comment or in PR description? |
Update the PR description in this PR: sonic-net/sonic-buildimage#8715 |
qiluo-msft
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft PR to help review patch file change in sonic-net/sonic-buildimage#8715
The code change in this PR include:
Support debug=on setting.
Support put server address and secret in same row.